Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll position restoration with ViewTransitions #110

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mood93
Copy link

@Mood93 Mood93 commented Jan 2, 2025

Fixes #93


For more details, open the Copilot Workspace session.

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for accessible-astro ready!

Name Link
🔨 Latest commit 4dfef3d
🔍 Latest deploy log https://app.netlify.com/sites/accessible-astro/deploys/6776cecdb064e500083fa935
😎 Deploy Preview https://deploy-preview-110--accessible-astro.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mood93
Copy link
Author

Mood93 commented Jan 2, 2025

Hey @markteekman, great project! I think I fixed this bug.

@markteekman
Copy link
Owner

@Mood93 thanks for submitting the PR and trying to figure out what's happening 😄 I tested the deploy preview and it seems to be working! I'll get back to it later to test it some more but great find! 👍🏼

@markteekman markteekman self-assigned this Jan 6, 2025
@Mood93
Copy link
Author

Mood93 commented Jan 6, 2025

Thanks, I'm still trying to understand why this fixed it, and if it is indicative of a bug in Astro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View Transition scroll position not restored.
2 participants