Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: erwanMarmelab <[email protected]>
  • Loading branch information
djhi and erwanMarmelab authored Dec 12, 2024
1 parent a551e35 commit 809641a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/AccordionForm.md
Original file line number Diff line number Diff line change
Expand Up @@ -826,6 +826,6 @@ const PersonEdit = () => (

Note that you **must** set the `<AccordionForm resetOptions>` prop to `{ keepDirtyValues: true }`. If you forget that prop, any change entered by the end user after the autosave but before its acknowledgement by the server will be lost.

If you're using it in an `<Edit>` page, you must also use a `pessimistic` or `optimistic` [`mutationMode`](https://marmelab.com/react-admin/Edit.html#mutationmode) - `<AutoSave>` doesn't work with the default `mutationMode="undoable"`.
If you're using it in an `<Edit>` page, you must also use a `pessimistic` or `optimistic` [`mutationMode`](./Edit.md#mutationmode) - `<AutoSave>` doesn't work with the default `mutationMode="undoable"`.

Check [the `<AutoSave>` component](./AutoSave.md) documentation for more details.
8 changes: 4 additions & 4 deletions docs/AuthRBAC.md
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ export const PostList = () => (
// Users will only see the authorized columns when clicking on the export button.
```

**Tip**: If you need a custom [`exporter`](https://marmelab.com/react-admin/List.html#exporter), you can use `useExporterWithAccessControl` to apply access control to the exported records:
**Tip**: If you need a custom [`exporter`](./List.md#exporter), you can use `useExporterWithAccessControl` to apply access control to the exported records:

```tsx
import { List, useExporterWithAccessControl } from '@ra-enterprise/ra-rbac';
Expand Down Expand Up @@ -521,7 +521,7 @@ export const PostList = () => <List actions={<ListActions />}>...</List>;

## `<ExportButton>`

Replacement for react-admin's [`<ExportButton>`](https://marmelab.com/react-admin/Buttons.html#exportbutton) that checks users have the `'export'` permission before rendering. Use it if you want to provide your own `actions` to the `<List>`:
Replacement for react-admin's [`<ExportButton>`](./Buttons.md#exportbutton) that checks users have the `'export'` permission before rendering. Use it if you want to provide your own `actions` to the `<List>`:

```tsx
import { CreateButton, List, TopToolbar } from 'react-admin';
Expand All @@ -542,7 +542,7 @@ export const PostList = () => (
);
```

It accepts the following props in addition to the default [`<ExportButton>` props](https://marmelab.com/react-admin/Buttons.html#props-8):
It accepts the following props in addition to the default [`<ExportButton>` props](./Buttons.md#props-8):

| Prop | Required | Type | Default | Description |
| -------------------- | -------- | ----------------- | ---------- | ---------------------------------------------------------------------- |
Expand Down Expand Up @@ -916,7 +916,7 @@ const ProductEdit = () => (

## `<CloneButton>`

Replacement for react-admin's [`<CloneButton>`](https://marmelab.com/react-admin/Buttons.html#clonebutton) that checks users have the `'clone'` permission before rendering. Use it if you want to provide your own `actions` to the `<Edit>`:
Replacement for react-admin's [`<CloneButton>`](./Buttons.md#clonebutton) that checks users have the `'clone'` permission before rendering. Use it if you want to provide your own `actions` to the `<Edit>`:

```tsx
import { Edit, TopToolbar } from 'react-admin';
Expand Down
2 changes: 1 addition & 1 deletion docs/LongForm.md
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,6 @@ const PersonEdit = () => (

Note that you **must** set the `<LongForm resetOptions>` prop to `{ keepDirtyValues: true }`. If you forget that prop, any change entered by the end user after the autosave but before its acknowledgement by the server will be lost.

If you're using it in an `<Edit>` page, you must also use a `pessimistic` or `optimistic` [`mutationMode`](https://marmelab.com/react-admin/Edit.html#mutationmode) - `<AutoSave>` doesn't work with the default `mutationMode="undoable"`.
If you're using it in an `<Edit>` page, you must also use a `pessimistic` or `optimistic` [`mutationMode`](./Edit.md#mutationmode) - `<AutoSave>` doesn't work with the default `mutationMode="undoable"`.

Check [the `<AutoSave>` component](./AutoSave.md) documentation for more details.

0 comments on commit 809641a

Please sign in to comment.