Fix useDelete does not invalidate cache in pessimistic mode

marmelab · Jan 14, 2025 · d179c21 · d179c21
1 parent 4bdf7b5
commit d179c21
Showing 1 changed file with 11 additions and 23 deletions.
diff --git a/packages/ra-core/src/dataProvider/useDelete.ts b/packages/ra-core/src/dataProvider/useDelete.ts
@@ -256,16 +256,6 @@ export const useDelete = <
             context: unknown
         ) => {
             if (mode.current === 'pessimistic') {
-                // update the getOne and getList query cache with the new result
-                const {
-                    resource: callTimeResource = resource,
-                    id: callTimeId = id,
-                } = variables;
-                updateCache({
-                    resource: callTimeResource,
-                    id: callTimeId,
-                });
-
                 if (
                     mutationOptions.onSuccess &&
                     !hasCallTimeOnSuccess.current
@@ -281,12 +271,10 @@ export const useDelete = <
             variables: Partial<UseDeleteMutateParams<RecordType>> = {},
             context: { snapshot: Snapshot }
         ) => {
-            if (mode.current === 'optimistic' || mode.current === 'undoable') {
-                // Always refetch after error or success:
-                context.snapshot.forEach(([queryKey]) => {
-                    queryClient.invalidateQueries({ queryKey });
-                });
-            }
+            // Always refetch after error or success:
+            context.snapshot.forEach(([queryKey]) => {
+                queryClient.invalidateQueries({ queryKey });
+            });
 
             if (mutationOptions.onSettled && !hasCallTimeOnSettled.current) {
                 return mutationOptions.onSettled(
@@ -330,13 +318,6 @@ export const useDelete = <
             mode.current = mutationMode;
         }
 
-        if (mode.current === 'pessimistic') {
-            return mutation.mutate(
-                { resource: callTimeResource, ...callTimeParams },
-                otherCallTimeOptions
-            );
-        }
-
         const {
             id: callTimeId = id,
             previousData: callTimePreviousData = previousData,
@@ -372,6 +353,13 @@ export const useDelete = <
             [] as Snapshot
         );
 
+        if (mode.current === 'pessimistic') {
+            return mutation.mutate(
+                { resource: callTimeResource, ...callTimeParams },
+                otherCallTimeOptions
+            );
+        }
+
         // Cancel any outgoing re-fetches (so they don't overwrite our optimistic update)
         await Promise.all(
             snapshot.current.map(([queryKey]) =>