Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <FormDataConsumer> causes its children to flicker #10417

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Dec 16, 2024

Problem

Fixes #10415

Solution

Keep a stable reference to the children function

How To Test

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why): can't find a way to unit test this
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

@djhi djhi added the RFR Ready For Review label Dec 16, 2024
@slax57 slax57 added this to the 5.4.3 milestone Dec 17, 2024
@slax57 slax57 merged commit d135bd3 into master Dec 17, 2024
0 of 2 checks passed
@slax57 slax57 deleted the fix-form-data-consumer-flicker branch December 17, 2024 08:57
@slax57 slax57 changed the title Fix form data consumer flicker Fix <FormDataConsumer> causes its children to flicker Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormDataConsumer component cause rerendering or glitching the input upon selection/reset the value
2 participants