fix <Authenticated> - never render its children when checkAuth return… #10443
+30
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s error
Problem
Using
<Authenticated>
, we can witness a quick render with the children provided whereas it shouldn't. This happens because react-query returns an object with isPending=False but the callback for error has not been called yet.Solution
Checking for isError and isPending seems to be more reliable
How To Test
I added a test to demonstrate the problem
Additional Checks
master
for a bugfix, ornext
for a featureAlso, please make sure to read the contributing guidelines.