Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date-fns import that pulls in entire library in consuming apps #310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acorncom
Copy link

I recently bumped date-fns up to v4 for a client and upgraded to 3.2.0 of this library as well. In the process, the entire date-fns library started getting pulled in, although we'd very carefully worked to ensure we were importing just the pieces we needed (and had made sure that was working).

It took a bit of digging, but it turns out the addition of the getDefaultOptions import as part of the 3.2.0 upgrade led to the entire date-fns library getting pulled in, as the import from the main barrel file of date-fns then means that consumers can't tree-shake properly.

This two-line patch gets this app's bundle size back where we expected.

Thanks for your work on this library over the years, it's been much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant