Fix date-fns import that pulls in entire library in consuming apps #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently bumped date-fns up to v4 for a client and upgraded to
3.2.0
of this library as well. In the process, the entiredate-fns
library started getting pulled in, although we'd very carefully worked to ensure we were importing just the pieces we needed (and had made sure that was working).It took a bit of digging, but it turns out the addition of the
getDefaultOptions
import as part of the 3.2.0 upgrade led to the entiredate-fns
library getting pulled in, as the import from the main barrel file ofdate-fns
then means that consumers can't tree-shake properly.This two-line patch gets this app's bundle size back where we expected.
Thanks for your work on this library over the years, it's been much appreciated!