Peak shaving: Update after set_peak_shaving #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marq24
pushed a commit
that referenced
this pull request
Oct 27, 2023
* Added data update after set_peak shaving * Refactoring of Service set_peakshaving Added data update after set_peak shaving (#40)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thx for yor effort to merge the PR.
Here a quick update, that takes care that an update takes place after an update of peak shaving information.
I havn't found a way to add dynamic information to services.yaml like current data or just to show the input-fields that are needed. (E.g. I would love to make "Battery capacity limit" and "End time" just in that case visible, when a user selects the "Manuel" Peak Shaving Mode)