-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PTMA AA FF to polyply library [10.1021/acs.macromol.3c00141] #276
Conversation
@ricalessandri if you register here you can get a free T-shirt if you make 4 PRs in Oktober for the Hacktoberfest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that this molecule does not have specific links to determine the chirality of the polymer. Have you looked at the distribution of the 5 3 1 4 dihedral? If it is not always positive or negative it should be good as atactic polymer but if it has the tendency to lean on one side we might have to add specific potentials.
I have not looked into that (sorry, I remember about our discussions but did not have the bandwidth for that). Maybe this is a good chance. I will try to produce a plot asap. I am however unsure whether I would really want to introduce things in this model at this point since this is the model that I have been using for the simulations. |
Sure thing we just have to know if it gives an atactic or isotactic polymer. Either way is fine for me. |
Finally getting to close this, some things to fix before merging so I don't forget:
|
Alright, I'm finally at it. This is one of the 3 things left to close this PR: tacticity.
With a 40-60% ratio. I guess this would converge to 50-50 with more (and/or longer) chains.
Not sure if you want this more quantitative. In case, what's a smart metric for this? |
I resolved the previous issues. I guess this is ready to be merged, @fgrunewald . |
One test fails but I think it's not related to this .ff file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I think the polymer is indeed atactic. I'm happy with the distributions and don't need an more in-depth argument. In fact when you build multiple chains in a melt will be rather realistic as they have all slightly different tacticity.
My only optional suggestion would be to add a warning link, which will be triggered when someone misses the terminal groups. I've added an example for P3HT. It looks like this:
polyply_1.0/polyply/data/gromos53A6/links.ff
Lines 63 to 70 in 1ecd4d5
[ link ] | |
[ atoms ] | |
CT2 {"resname": "P3HT"} | |
[ warning ] | |
You should patch P3HT with a H-terminal residues. Use -seq Hter:1 P3HT:4 Hter:1 | |
[ non-edges ] | |
CT2 +H1 | |
CT2 +CT5 |
You'd just have to replace CT2 by the linking carbon atom of the main repeat and adopt the warning. As your terminii are asymmetric I'm not sure though we can filter out which one is missing. But that would not be problematic in my opinion. Again totally optionl.
@ricalessandri you can also consider adding a line on the news section of the readme file to promote your paper |
Thanks for the nice ideas! I've added the warning, it works: polyply_1.0/polyply/data/oplsaaLigParGen/links_PTMA.ff Lines 164 to 174 in 006e37e
I didn't include that
because it didn't make any difference in the resulting As a side note, I played with the behavior and the warnings will be printed twice for each residue (i.e., 8 times for I will include the news piece in the other PR later today. |
@ricalessandri the non-edges are specifically to reduce the number of warnings being printed and in principle, you could even use them to specifically target only one end, like if you miss CH3b it would only do 1 warning. However, there is a small syntax mistake in the non-edges of the first residue. It should first mention the atom that is also in the atoms directive. So it should be:
If you adjust this, the PR should be ready to go. |
@fgrunewald done! I implemented and tested and works as expected (1 warning for CH3a if I miss that, 1 warning for CH3b if I miss that, of 2 warnings if I miss both) - fantastic! |
PR for contributing the OPLS-based AA FF developed for PTMA in https://arxiv.org/abs/2209.02072.
I will shortly add a test. Also open a separate PR to contribute CG model(s).