-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue 285 #331
fix issue 285 #331
Conversation
Bonded parameters look good on testing, but the VS-BB exclusions don't seem to be generated at all? for generating coordinates the molecule checking fails too, error of two disjointed parts |
@csbrasnett I fixed the exclusions. For the structure coordinate generation works though? Can you make a example available to me. |
Looks to work now |
@csbrasnett the peprint is already out. Are these parameters up to date? Can we merge and release it? Also can you add the citation to the preprint paper? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nitpick about the minimizer, the rest looks fine.
However, it seems @pckroon needs to approve this PR.
@csbrasnett this is a clean PR with all changes we did yesterday. I also fixed the template generation issue. Can you test this branch?
To Do