Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 285 #331

Merged
merged 13 commits into from
Apr 22, 2024
Merged

fix issue 285 #331

merged 13 commits into from
Apr 22, 2024

Conversation

fgrunewald
Copy link
Member

@fgrunewald fgrunewald commented Jun 27, 2023

@csbrasnett this is a clean PR with all changes we did yesterday. I also fixed the template generation issue. Can you test this branch?

To Do

  • add test for volume computation
  • make sure IDP parameters are correct
  • add citation to IDP paper
  • add warning to include new martini itp file??
  • write user tutorial

@csbrasnett
Copy link
Collaborator

Bonded parameters look good on testing, but the VS-BB exclusions don't seem to be generated at all?

for generating coordinates the molecule checking fails too, error of two disjointed parts

@fgrunewald
Copy link
Member Author

@csbrasnett I fixed the exclusions. For the structure coordinate generation works though? Can you make a example available to me.

@csbrasnett
Copy link
Collaborator

Looks to work now

@fgrunewald fgrunewald added the wait_for_publication can only be merged when paper is published label Jun 28, 2023
@fgrunewald fgrunewald added the wait_for_vermouth This PR is waiting for new release of vermouth/martinize label Oct 17, 2023
@fgrunewald
Copy link
Member Author

fgrunewald commented Apr 17, 2024

@csbrasnett the peprint is already out. Are these parameters up to date? Can we merge and release it?

Also can you add the citation to the preprint paper?

Copy link
Member Author

@fgrunewald fgrunewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick about the minimizer, the rest looks fine.

However, it seems @pckroon needs to approve this PR.

polyply/src/minimizer.py Outdated Show resolved Hide resolved
@fgrunewald fgrunewald merged commit abd3e25 into master Apr 22, 2024
8 checks passed
@fgrunewald fgrunewald deleted the idp-new branch April 22, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wait_for_publication can only be merged when paper is published wait_for_vermouth This PR is waiting for new release of vermouth/martinize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants