Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big smiles #358
Big smiles #358
Changes from all commits
40b89af
05ed045
82a2acc
257b76b
061c8ef
20e2e49
f505129
0c67ecc
52235c9
9a0a674
ceccc3d
158fd37
8f2887f
7cb3b4c
097ec84
514ba1b
d97632d
c4f1652
7a5dd1f
2b9e7a9
b6d891f
a867329
b6f5cc0
f965e1d
0335956
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 71 in polyply/src/big_smile_mol_processor.py
Codecov / codecov/patch
polyply/src/big_smile_mol_processor.py#L71
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Def?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of class? I like the class organization a bit more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why is it called DefBigSmileParser? The Def looks strange to me. Also, "smiles" with s ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh yes; So the thing is that the format is not exactly a BigSMILE. This is a leftover (indeed good catch) of the original idea to call it
Defined-Big-SMILE
in short DefBigSmile but I think we're gravitating towards another name now. I'll leave this open and once it's decided adjust itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
VALENCES[element][0]
doesn't always work. You need to select the smallest valence that is larger than the current number of bonds present.Also, why +1?