Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: install busted to run lua tests #1205

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

fischerling
Copy link
Contributor

Install busted in the CI pipelines to run the included lua tests.

Copy link
Collaborator

@rnpnr rnpnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vis 788e9b8 +curses +lua +tre
cursor OK
lines OK
map-basic OK
file-empty OK
Tests ok 4/4

Thanks! Applying!

@rnpnr rnpnr merged commit d8276d9 into martanne:master Sep 9, 2024
19 checks passed
@fischerling
Copy link
Contributor Author

vis 788e9b8 +curses +lua +tre
cursor OK
lines OK
map-basic OK
file-empty OK
Tests ok 4/4

Unfortunatly this does not mean that all tests passed.
For all those not watching the mailing list.
Bug report on the mailing list

@fischerling
Copy link
Contributor Author

Maybe we should apply jeremybobbin/vis-test@db8210d and drop busted altogether.

Alternativly, if we want to keep busted, there is fischerling@dab1f4a to fix the test failure detection.

@mcepl
Copy link
Contributor

mcepl commented Sep 10, 2024 via email

@rnpnr
Copy link
Collaborator

rnpnr commented Sep 10, 2024

The reason I didn't apply it was because Jeremy said he wasn't entirely happy with it. I'm not really seeing any particular issue with it. I'll confirm on the mailing list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants