Skip to content

feat(mro): Improve martian_make_mro #604

feat(mro): Improve martian_make_mro

feat(mro): Improve martian_make_mro #604

Triggered via pull request June 12, 2024 17:00
Status Success
Total duration 33s
Artifacts

clippy.yml

on: pull_request
clippy_check
24s
clippy_check
Fit to window
Zoom out
Zoom in

Annotations

8 warnings
clippy_check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: 10XGenomics/clippy-check@main. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
variables can be used directly in the `format!` string: martian/src/mro.rs#L36
warning: variables can be used directly in the `format!` string --> martian/src/mro.rs:36:17 | 36 | / assert!( 37 | | width >= min_width, 38 | | "Need a minimum width of {}. Found {}", 39 | | min_width, 40 | | width 41 | | ); | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: requested on the command line with `-W clippy::uninlined-format-args`
variables can be used directly in the `format!` string: martian/src/mro.rs#L113
warning: variables can be used directly in the `format!` string --> martian/src/mro.rs:113:13 | 113 | writeln!(f, " {},", formatted_line)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 113 - writeln!(f, " {},", formatted_line)?; 113 + writeln!(f, " {formatted_line},")?; |
variables can be used directly in the `format!` string: martian/src/mro.rs#L526
warning: variables can be used directly in the `format!` string --> martian/src/mro.rs:526:13 | 526 | / assert!( 527 | | self.name != token, 528 | | "Martian token {} cannot be used as field name", 529 | | token 530 | | ); | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: martian/src/mro.rs#L926
warning: variables can be used directly in the `format!` string --> martian/src/mro.rs:926:13 | 926 | / write!( 927 | | f, 928 | | "{params:<ty_width$}", 929 | | params = chunk_in_out, 930 | | ty_width = ty_width 931 | | )?; | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: martian/src/lib.rs#L359
warning: variables can be used directly in the `format!` string --> martian/src/lib.rs:359:9 | 359 | / assert!( 360 | | header_comment 361 | | .lines() 362 | | .all(|line| line.trim_end().is_empty() || line.starts_with('#')), 363 | | "All non-empty header lines must start with '#', but got\n{}", 364 | | header_comment 365 | | ); | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
variables can be used directly in the `format!` string: martian-derive/src/lib.rs#L328
warning: variables can be used directly in the `format!` string --> martian-derive/src/lib.rs:328:9 | 328 | / format!( 329 | | "{}. You are trying to use it on {} trait implementation.", 330 | | ATTR_NOT_ON_TRAIT_IMPL_ERROR, last_ident 331 | | ), | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: requested on the command line with `-W clippy::uninlined-format-args`
variables can be used directly in the `format!` string: martian-derive/src/lib.rs#L555
warning: variables can be used directly in the `format!` string --> martian-derive/src/lib.rs:555:17 | 555 | / format!( 556 | | "Field name {} is not allowed here since it is a martian keyword", 557 | | name 558 | | ), | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args