feat: model special resource requests too #512
Conversation
| @@ -3,7 +3,6 @@ | |||
| /// TODO: | |||
| /// - Handle default values for FileType | |||
| /// - Repo wide reorganization | |||
| extern crate proc_macro; | |||
| pub struct Resource { | ||
| #[serde(rename = "__mem_gb")] | ||
| mem_gb: Option<isize>, | ||
| #[serde(rename = "__threads")] | ||
| threads: Option<isize>, | ||
| #[serde(rename = "__vmem_gb")] | ||
| vmem_gb: Option<isize>, | ||
| #[serde(rename = "__special")] | ||
| special: Option<String>, |
There was a problem hiding this comment.
This cannot be specified in the using section of the mro right?
There was a problem hiding this comment.
It can be specified
There was a problem hiding this comment.
Okay, to support it in the using section, we would need to update
martian-rust/martian/src/mro.rs
Line 657 in 7028107
martian-rust/martian-derive/src/lib.rs
Line 392 in 7028107
#[make_mro(special="...")]
There was a problem hiding this comment.
This should really be
| special: Option<String>, | |
| special: Option<&' static str>, |
There is no plausible use case for this being something other than a compile-time constant.
There was a problem hiding this comment.
(yes, I know this poses problems for deserialization but I can't think of a plausible case where you need to deserialize it either)
| @@ -2,25 +2,29 @@ | |||
| "chunks": [ | |||
| { | |||
| "__mem_gb": 1, | |||
| "__special": null, | |||
There was a problem hiding this comment.
This should not be written if special was unset. Please fix.
No description provided.