Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive getStartUrls #106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jackburridge
Copy link

@jwillmer
Copy link

I think pull request #194 covers this already.

@codoff
Copy link

codoff commented May 24, 2017

No, #194 add other functionality

@jwillmer
Copy link

Can u explain the difference? From the Screenshot he provided I can see that you can also add numeric values into the URL.
42441828-fdb7-11e6-9fc6-16c03c0a2a03

@codoff
Copy link

codoff commented May 24, 2017

Of course, see, I did not add numeric pattern - it was already. I added date pattern and make description how to use both.

In this pr, recursion is suggested, when several identical patterns are found in one URL.

#106 and #194 complement each other.

@jwillmer
Copy link

jwillmer commented May 24, 2017

Understood, thanks, I merged it to my fork.

@codoff @jackburridge could you write some tests for it or quickly manual test your changes in my fork? I like to make sure that it works as intended after merging both your solutions together.

Off topic: Really nice to see so many contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants