-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for vertical tables #204
Open
jwillmer
wants to merge
73
commits into
martinsbalodis:master
Choose a base branch
from
jwillmer:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set allowLocal to 'true' to allow private and local network IPs.
Allows for addresses like "http://example.com/search?mode=[1-10]&type=[1-10]"
Allow using regex groups to select in Text
The JSON to CSV export wasn't always valid. Use Papaparse.js library.
Was a left over from development
- JSON instead of CSV config backups - fixed tests
- Extended chrome fake api - merged CSV options
I started to merge all open pull requests into my fork. Feel free to merge it back! |
… found in one URL.
Moved change log with features more to the top and removed redundant information
- added dynamic columns for table selector
- Normalizing properties and columns after scraping
Fixed tests close #4
A selector to input a value (search term)
Nice PR 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the diff problems but Visual Studio might have changed the line ending format.
I have implemented vertical table support in the
SelectorTable.js
file and added a couple of test cases for it as well as an extension of the playground to test it.