workspace-update-stale: add a config knob to run automatically #4807
Conversation
|
Fixes issue #3820 |
|
In my opinion the PR contains three unrelated topics in the stack. As the first commit is a docs cleanup (1), the second two are moving the recovering commit logic into lib (2) (which makes it usable for the Google server) and then the actually advertised PR (3) which depends on (2). I think at least the first commit should be split out, since it has no relation to rest, the other two would be nice to have but can stay together. And all commits are missing a motivation, as it definitely is not obvious what they want to achieve. Quoted from contributing.md:
|
The only difference between (2) and (3) is one moves stuff to lib, the other to cli_util, I don't think they're very different. I split (1) to its own PR but it's still here too, I'm not sure how to set up dependent PRs with jj.
Added some more text to the commit descriptions. |
torquestomp
force-pushed
the
wus
branch
3 times, most recently
from
ffb9416
to
9bcf0b7
Compare
| impl<E> From<E> for SnapshotWorkingCopyError | ||
| where | ||
| E: Into<CommandError>, | ||
| { | ||
| fn from(value: E) -> Self { | ||
| Self::Command(value.into()) | ||
| } |
There was a problem hiding this comment.
nit: I wouldn't add automatic conversion because the caller should be careful to not map stale wc error to Command(_).
There was a problem hiding this comment.
Making this explicit makes snapshot_working_copy() pretty terrible; there are far more existing implicit conversions into CommandError than there are places that need to return an explicit StaleWorkingCopy error (10+ > 3)
This is to facilitate automatic update-stale in extensions and in the CommandHelper layer.
This is to facilitate automatic update-stale in extensions and in the CommandHelper layer.
This centralizes the logic so the cli helpers can use it.
This centralizes the logic so cli helpers can use it.
This significantly reduces toil for multi-workspace users, resolving issue martinvonz#3820
Checklist
If applicable:
CHANGELOG.md