⚡ Refactor: Possible null reference assignment (#729)

* 🐛 fix: Fix BlazorCurrentPrincipalAccessor in BlazorWebAssembly * test: Adjust unit testing * ⚡ Refactor: Possible null reference assignment * ⚡ refactor: Eliminate code odor
masastack · Aug 29, 2024 · d773522 · d773522
1 parent b757ee5
commit d773522
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/...ntity/Masa.Contrib.Authentication.Identity.BlazorWebAssembly/MasaComponentsClaimsCache.cs b/...ntity/Masa.Contrib.Authentication.Identity.BlazorWebAssembly/MasaComponentsClaimsCache.cs
@@ -6,7 +6,7 @@ namespace Masa.Contrib.Authentication.Identity.BlazorWebAssembly;
 public class MasaComponentsClaimsCache : IScopedDependency
 {
     public ClaimsPrincipal Principal { get; private set; }
-    private readonly AuthenticationStateProvider _authenticationStateProvider;
+    private readonly AuthenticationStateProvider? _authenticationStateProvider;
 
     public MasaComponentsClaimsCache(
         IClientScopeServiceProviderAccessor serviceProviderAccessor)

diff --git a/...entity/Tests/Masa.Contrib.Authentication.Identity.BlazorWebAssembly.Tests/IdentityTest.cs b/...entity/Tests/Masa.Contrib.Authentication.Identity.BlazorWebAssembly.Tests/IdentityTest.cs
@@ -105,10 +105,10 @@ public async Task TestIdentityByYamlAsync()
 
         var userRoles = userContext.GetUserRoles<int>().ToList();
         Assert.AreEqual(4, userRoles.Count);
-        Assert.AreEqual(true, userRoles.Contains(1));
-        Assert.AreEqual(true, userRoles.Contains(3));
-        Assert.AreEqual(true, userRoles.Contains(7));
-        Assert.AreEqual(true, userRoles.Contains(12));
+        Assert.IsTrue(userRoles.Contains(1));
+        Assert.IsTrue(userRoles.Contains(3));
+        Assert.IsTrue(userRoles.Contains(7));
+        Assert.IsTrue(userRoles.Contains(12));
     }
 
     [TestMethod]
@@ -154,9 +154,9 @@ public async Task TestIdentityByYamlAndCustomOptionsAsync()
 
         var userRoles = userContext.GetUserRoles<int>().ToList();
         Assert.AreEqual(4, userRoles.Count);
-        Assert.AreEqual(true, userRoles.Contains(1));
-        Assert.AreEqual(true, userRoles.Contains(3));
-        Assert.AreEqual(true, userRoles.Contains(7));
-        Assert.AreEqual(true, userRoles.Contains(12));
+        Assert.IsTrue(userRoles.Contains(1));
+        Assert.IsTrue(userRoles.Contains(3));
+        Assert.IsTrue(userRoles.Contains(7));
+        Assert.IsTrue(userRoles.Contains(12));
     }
 }