merge from dev

maschmann · Sep 14, 2024 · 412aa58 · 412aa58
2 parents 139fa65 + 48cc93a
commit 412aa58
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/Asm/Ansible/Command/AnsiblePlaybook.php b/Asm/Ansible/Command/AnsiblePlaybook.php
@@ -289,18 +289,21 @@ public function inventory(array $hosts = []): AnsiblePlaybookInterface
             return $this;
         }
 
+        // Wrapping each host in double quotes to avoid issues with spaces in host names.
+        $hosts = array_map(fn ($host) => sprintf('"%s"', $host), $hosts);
+
         // In order to let ansible-playbook understand that the given option is a list of hosts, the list must end by
         // comma "," if it contains just an entry. For example, supposing just a single host, "localhosts":
         //
         //   Wrong: --inventory="locahost"
         // Correct: --inventory="locahost,"
-        $hostList = implode(', ', $hosts);
+        $hostList = implode(',', $hosts);
 
         if (count($hosts) === 1) {
             $hostList .= ',';
         }
 
-        $this->addOption('--inventory', sprintf('"%s"', $hostList));
+        $this->addOption('--inventory', $hostList);
         $this->hasInventory = true;
 
         return $this;
@@ -751,4 +754,4 @@ private function checkInventory(): void
             $this->inventoryFile($inventory);
         }
     }
-}
+}
diff --git a/Tests/Asm/Ansible/Command/AnsiblePlaybookTest.php b/Tests/Asm/Ansible/Command/AnsiblePlaybookTest.php
@@ -732,11 +732,11 @@ public function testInventory(): void
             ],
             [
                 'input' => ['localhost'],
-                'expect' => '--inventory="localhost,"',
+                'expect' => '--inventory="localhost",',
             ],
             [
                 'input' => ['localhost', 'host1'],
-                'expect' => '--inventory="localhost, host1"',
+                'expect' => '--inventory="localhost","host1"',
             ],
 
         ];