feat: 링크 저장 URL 추가 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonghunAn
force-pushed
the
feature/create-post
branch
from
ddcebd5
to
4973875
Compare
Marades
reviewed
Jun 29, 2024
| @UseGuards(JwtGuard) | ||
| export class PostsController { | ||
| constructor(private readonly postsService: PostsService) { | ||
| this.postsService = postsService; |
Marades
reviewed
Jun 29, 2024
src/modules/posts/posts.service.ts
Outdated
| @Injectable() | ||
| export class PostsService { | ||
| constructor(private readonly postRepository: PostsRepository) { | ||
| this.postRepository = postRepository; |
J-Hoplin
reviewed
Jun 29, 2024
| @IsString() | ||
| @IsNotEmpty() | ||
| @ApiProperty({ description: '폴더 id', required: true }) | ||
| folderId: Types.ObjectId; |
There was a problem hiding this comment.
형 Request에서는 Types.ObjectId 인스턴스로 넘겨줄 수 없어서 이거는 string으로 바꿔주는게 좋을것같아!
There was a problem hiding this comment.
굿굿 맞아 string으로 쓰는게 좋을듯
Marades
reviewed
Jun 29, 2024
| }); | ||
| return true; | ||
| } catch (error) { | ||
| throw new InternalServerErrorException('create post DB error'); |
There was a problem hiding this comment.
요기 exception factory로 나중에 바까주라~
There was a problem hiding this comment.
이건 exception factory말고 기본 nest exception 쓰기로 결정!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 내용
추가 및 변경 사항
PR 중점사항
스크린샷