feat: 내 피드 전체조회 / 즐겨찾기 피드 조회 API 추가 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonghunAn
changed the title
hye-on
reviewed
Jul 5, 2024
src/modules/posts/dto/getPostDto.ts
Outdated
| this.userId = post.userId.toString(); | ||
| this.url = post.url; | ||
| this.title = post.title; | ||
| this.description = post.title; |
hye-on
reviewed
Jul 5, 2024
| async getPost( | ||
| @GetUser('id') userId: string, | ||
| @Query() pagingQuery: PaginationQuery, | ||
| @Query('isFavorite') is_favorite?: boolean, |
hye-on
reviewed
Jul 5, 2024
Comment on lines
+23
to
+25
| if (isFavorite !== null) { | ||
| query = query.where({ isFavorite: isFavorite }); | ||
| } |
There was a problem hiding this comment.
(/¯◡‿◡)/¯✧·˚ : *✧·˚ : *
isFavorite 이 undefined일 일은 없나?? 궁금쓰
There was a problem hiding this comment.
응응 default값을 false로 해뒀어!
hye-on
reviewed
Jul 5, 2024
Comment on lines
+26
to
+27
| const post_list = await query.lean().exec(); | ||
| return post_list; |
hye-on
reviewed
Jul 5, 2024
| import { GetPostDto } from '@src/modules/posts/dto/getPostDto'; | ||
|
|
||
| export class PostListResponse { | ||
| @ApiProperty({ type: Number, description: '피드 총 개수' }) |
There was a problem hiding this comment.
타입에 number말고 Number 쓴이유 궁금쓰
There was a problem hiding this comment.
property type줄 때는 Number 타입으로 줘야하더라고~
https://docs.nestjs.com/openapi/types-and-parameters
hye-on
reviewed
Jul 5, 2024
| this.description = post.title; | ||
| this.isFavorite = post.isFavorite; | ||
| this.createdAt = post.createdAt; | ||
| this.updatedAt = post.updatedAt; |
There was a problem hiding this comment.
〆(・∀・＠)
updatedAt
이거 줘야되나용?
There was a problem hiding this comment.
아 나중에 ai 요약 생기면 description이 추가되면서 업데이트가 될꺼라 updateAt도 같이 내려줬어!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 내용
추가 및 변경 사항
PR 중점사항
스크린샷