폴더 목록 및 기본폴더 생성 #40
Closed
폴더 목록 및 기본폴더 생성 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marades
force-pushed
the
feat/folder-list-default-folders
branch
from
01e8d45
to
99a08ed
Compare
|
수고했어 형!! |
hye-on
reviewed
Jul 8, 2024
Comment on lines
3
to
8
| DEFAULT = 'default', | ||
|
|
||
| /** 실제 DB에 들어가지는 않고 클라이언트에 내려주기 위해 있는 값 타입 */ | ||
| ALL = 'all', | ||
| FAVORITE = 'favorite', | ||
| } |
There was a problem hiding this comment.
그럼 DEFAULT 인 폴더는 "나중에 읽을 링크" 만 있는건강 궁금쓰
hye-on
reviewed
Jul 8, 2024
Comment on lines
+3
to
+9
| export class FolderDomain { | ||
| userId: string; | ||
|
|
||
| name: string; | ||
|
|
||
| type: FolderType; | ||
| } |
hye-on
reviewed
Jul 8, 2024
Comment on lines
+4
to
8
| export interface FolderListServiceDto { | ||
| /** */ | ||
| defaultFolders: any[]; | ||
| customFolders: any[]; | ||
| } |
hye-on
reviewed
Jul 8, 2024
Comment on lines
+57
to
+59
| type: FolderType.ALL, | ||
| userId: new MongooseSchema.Types.ObjectId(userId), | ||
| postCount: allPostCount, |
hye-on
reviewed
Jul 8, 2024
Comment on lines
18
to
+19
| constructor(data: FolderDocument) { | ||
| this.id = data._id.toString(); | ||
| this.id = data._id ? data._id.toString() : data.id; |
There was a problem hiding this comment.
_id가 없으면 data.id 주는거 맞징
근데 FolderDocument에 id가 없는것 같은데(any 타입 넘겨서) 임시로 해둔건가?
JonghunAn
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 내용
추가 및 변경 사항
PR 중점사항
스크린샷