[Re] Onboard 관련 API #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marades
reviewed
Jul 17, 2024
| @@ -50,6 +51,7 @@ | |||
| "class-validator": "^0.14.1", | |||
| "cross-env": "^7.0.3", | |||
| "express": "^4.19.2", | |||
| "lodash": "^4.17.21", | |||
There was a problem hiding this comment.
〆(・∀・＠)
lodash 가 좀 무거운 걸로 알고 있는데 shuffle만 쓴다면 직접 구현하거나 다른 대안을 생각해보면 어떨까? 1.4Mb 던데 유틸 라이브러리치곤 많이 무겁다고 생각됑!
최근에 토스에서 낸 라이브러리인데 같은 기능도 있고 얘네는 경량화나 최적화도 많이 해놔서 좋은 대안이 될 수도 있을 거 같은데 준호 생각도 궁금쓰~
https://es-toolkit.slash.page/intro.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 내용
추가 및 변경 사항
PR 중점사항
@hye-on 혜온이가 #43 에서 남겨줬던 코멘트 대해서 나도 @JonghunAn 종훈이형이랑 동일한 의견이야! 온보딩이 고도화 할때 더 늘어날 수 도 있고, 이에 따라 다른 모듈간의 의존성이 생길 수 도 있을꺼라고 생각해서 따로 분리했어!
스크린샷