Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: URL fetch 요청 시 redircect 및 method 옵션 제거 #98

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

JonghunAn
Copy link
Member

PR 내용

추가 및 변경 사항

리다이렉트 되야하는 URL에 대해서 그냥 fetch 요청할 경우 데이터를 못가져오는 케이스 때문에 다시 원복처리

@J-Hoplin

PR 중점사항

리뷰어가 중점적으로 봐야하는 부분에 대해 적어주세요!

스크린샷

@github-actions github-actions bot added fix 버그 수정 document 문서화 관련 작업 수정 및 생성 labels Aug 5, 2024
Comment on lines -17 to -18
method: 'GET',
redirect: 'manual',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redirect를 maunal로 두면 리다이렉트를 못시키게끔 강제하는건데
보통 URL들이 redirect해서 일반적으로 링크 공유하면 redirect를 해야 정상적인 URL을 받아올 수 있는경우가 더 많아서 원복했음!
@hye-on , @Marades , @J-Hoplin
https://velog.io/@adam2/2019-12-25-1512-%EC%9E%91%EC%84%B1%EB%90%A8

@JonghunAn JonghunAn merged commit bd3d0a6 into develop Aug 5, 2024
2 checks passed
@J-Hoplin J-Hoplin deleted the fix/url-fetch branch August 11, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document 문서화 관련 작업 수정 및 생성 fix 버그 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant