-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mashong Mission Event로 분리 #453
Open
eunjungL
wants to merge
1
commit into
develop
Choose a base branch
from
feature/mashong-mission-event
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
mashup-domain/src/main/java/kr/mashup/branding/service/mashong/dto/MissionEventType.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package kr.mashup.branding.service.mashong.dto; | ||
|
|
||
| public enum MissionEventType { | ||
|
|
||
| APPLY, | ||
| SET_TO_VALUE, | ||
| ; | ||
|
|
||
| public boolean isApplyType() { | ||
| return this.equals(APPLY); | ||
| } | ||
| } |
22 changes: 22 additions & 0 deletions
22
...up-domain/src/main/java/kr/mashup/branding/service/mashong/event/MashongMissionEvent.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package kr.mashup.branding.service.mashong.event; | ||
|
|
||
|
|
||
| import kr.mashup.branding.domain.mashong.MissionStrategyType; | ||
| import kr.mashup.branding.domain.member.MemberGeneration; | ||
| import kr.mashup.branding.service.mashong.dto.MissionEventType; | ||
| import lombok.Getter; | ||
| import lombok.RequiredArgsConstructor; | ||
|
|
||
| @Getter | ||
| @RequiredArgsConstructor | ||
| public class MashongMissionEvent { | ||
|
|
||
| private final MissionStrategyType missionStrategyType; | ||
| private final MemberGeneration memberGeneration; | ||
| private final Double value; | ||
| private final MissionEventType eventType; | ||
|
|
||
| public boolean isApplyEvent() { | ||
| return eventType.isApplyType(); | ||
| } | ||
| } |
18 changes: 18 additions & 0 deletions
18
.../src/main/java/kr/mashup/branding/service/mashong/event/MashongMissionEventPublisher.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package kr.mashup.branding.service.mashong.event; | ||
|
|
||
| import lombok.RequiredArgsConstructor; | ||
| import lombok.extern.slf4j.Slf4j; | ||
| import org.springframework.context.ApplicationEventPublisher; | ||
| import org.springframework.stereotype.Component; | ||
|
|
||
| @Slf4j | ||
| @Component | ||
| @RequiredArgsConstructor | ||
| public class MashongMissionEventPublisher { | ||
|
|
||
| private final ApplicationEventPublisher eventPublisher; | ||
|
|
||
| public void publish(MashongMissionEvent event) { | ||
| eventPublisher.publishEvent(event); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
mashup-member/src/main/java/kr/mashup/branding/ui/mashong/MashongMissionEventListener.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| package kr.mashup.branding.ui.mashong; | ||
|
|
||
| import kr.mashup.branding.config.async.ThreadPoolName; | ||
| import kr.mashup.branding.facade.mashong.MashongMissionFacadeService; | ||
| import kr.mashup.branding.service.mashong.event.MashongMissionEvent; | ||
| import lombok.RequiredArgsConstructor; | ||
| import lombok.extern.slf4j.Slf4j; | ||
| import org.springframework.scheduling.annotation.Async; | ||
| import org.springframework.stereotype.Component; | ||
| import org.springframework.transaction.annotation.Propagation; | ||
| import org.springframework.transaction.annotation.Transactional; | ||
| import org.springframework.transaction.event.TransactionalEventListener; | ||
|
|
||
| @Slf4j | ||
| @RequiredArgsConstructor | ||
| @Component | ||
| public class MashongMissionEventListener { | ||
|
|
||
| private final MashongMissionFacadeService mashongMissionFacadeService; | ||
|
|
||
| @Async(value = ThreadPoolName.MASHONG_MISSION_THREAD_POOL) | ||
| @Transactional(propagation = Propagation.NEVER) | ||
| @TransactionalEventListener | ||
| public void handleMashongMissionEvent(MashongMissionEvent event) { | ||
| log.info("MASHONG_MISSION_{}_EVENT_LISTEN :: memberGenerationId = {}", | ||
| event.getEventType(), | ||
| event.getMemberGeneration().getId() | ||
| ); | ||
|
|
||
| if (event.isApplyEvent()) { | ||
| mashongMissionFacadeService.apply( | ||
| event.getMissionStrategyType(), | ||
| event.getMemberGeneration(), | ||
| event.getValue() | ||
| ); | ||
| return; | ||
| } | ||
|
|
||
| mashongMissionFacadeService.setToValue( | ||
| event.getMissionStrategyType(), | ||
| event.getMemberGeneration(), | ||
| event.getValue() | ||
| ); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[의견]
단순의견입니닷 enum이 있으니까 switch로 하는건어떤가유~ 그냥 의견이라 편하게 ㄲㄲ