Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: 길찾기 Client 추가 #115

Merged
merged 14 commits into from
Aug 2, 2024
Merged

feature: 길찾기 Client 추가 #115

merged 14 commits into from
Aug 2, 2024

Conversation

thguss
Copy link
Member

@thguss thguss commented Jul 28, 2024

이슈

closed #113

변경 사항

  • 길찾기 Client를 추가했습니다.
  • 티맵 Open API를 활용했습니다.

스크린샷

부연 설명

  • Distance DTO에서 totalDistance는 m, totalTime은 초 단위입니다.
  • API 구현 과정에서 스웨거 내 정보 추가할 예정입니다!

체크리스트

  • Lint 적용 여부
  • 빌드 성공 여부
  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가
  • PR에 대해 구체적으로 설명이 되어있는가

@thguss
Copy link
Member Author

thguss commented Jul 28, 2024

출격준비

Copy link

✅ 빌드 성공 ✅
🚀 출격 준비 완료 👨🏻‍🚀

Copy link
Member

@KimDoubleB KimDoubleB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ㅎㅎㅎㅎ 💯
TMAP API는 사용해보지 않았는데 꽤나 많은 정보를 제공하네요 ㅋㅋㅋ 👍🏻
몇 가지 리뷰 적어봤어요 ㅎㅎㅎ

@thguss
Copy link
Member Author

thguss commented Aug 1, 2024

출격준비

Copy link

github-actions bot commented Aug 1, 2024

✅ 빌드 성공 ✅
🚀 출격 준비 완료 👨🏻‍🚀

Copy link
Member

@KimDoubleB KimDoubleB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 반영하느라 고생하셨습니다 👍🏻

@thguss
Copy link
Member Author

thguss commented Aug 2, 2024

출격준비

Copy link

github-actions bot commented Aug 2, 2024

✅ 빌드 성공 ✅
🚀 출격 준비 완료 👨🏻‍🚀

@thguss thguss merged commit 9f96a4e into develop Aug 2, 2024
1 check passed
@thguss thguss deleted the feature/#113-tmap-client branch August 2, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: TMAP 관련 Client 추가
3 participants