Add immutable project #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
There was a problem hiding this comment.
Was it intended to push this file ?
| @@ -6,3 +6,5 @@ export const CHUNK_NB_TAG = k.nextKey(); // 2 as u8 | |||
| export const METADATA_TAG = k.nextKey(); // 3 as u8 | |||
| export const MAX_STORAGE_VALUE_SIZE = k.nextKey(); // 4 as u8 | |||
| export const FILES_PATH_LIST = new ConstantManager<Array<string>, u8>(k); // k will be 5 as u8 | |||
| export const IMMUTABLE = new ConstantManager<bool, u8>(k); // k will be 6 as u8 | |||
| export const DEWEB_VERSION = new ConstantManager<u32, u8>(k); // k will be 7 as u8 | |||
There was a problem hiding this comment.
I was more thinking about something like a \007DEWEB_VERSION
So we have a byte at the beginning, and then the variable name. So when looking into the ledger, we can check if this key exists. If so, we know it's a website.
But if we just use 7, a lot of SC might use it, so we will note a lot of SCs as websites while they won't be websites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.