Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #261

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Fix CI #261

merged 3 commits into from
Jun 27, 2023

Conversation

bilboquet
Copy link
Contributor

@bilboquet bilboquet commented Jun 22, 2023 •
edited
Loading

Solve #258

@bilboquet
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jun 22, 2023
@bors
Try #261:
85af716
@bors
Copy link
Contributor

bors bot commented Jun 22, 2023

try

Build failed:

Jean-François Morcillo added 2 commits June 22, 2023 17:16
Fix CI
e0aa36e 
Signed-off-by: Jean-François Morcillo <[email protected]>
Don't generate unused documentation that has to be replaced soon
1f4a794 
Signed-off-by: Jean-François Morcillo <[email protected]>
@bilboquet bilboquet marked this pull request as ready for review June 22, 2023 15:16
@aoudiamoncef
Copy link
Contributor

aoudiamoncef commented Jun 22, 2023 •
edited
Loading

@bilboquet why do we have to use protoc ? if we did the things right, importing massa-proto-rs should be good

@bilboquet
Copy link
Contributor Author

@bilboquet why do we have to use protoc ?

It's stated in the doc that prost depends on it.
Coverage use --feature=all (something like that), so it trigger a dep to protoc.
The PR I'm working on will remove all this and depends on massa-proto-rs so I go strait to make the CI ok and don't loose too many time.

damip
damip previously approved these changes Jun 26, 2023
View reviewed changes
@bilboquet
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Jun 26, 2023
@bors
Merge #261
87b5713 
261: Fix CI r=bilboquet a=bilboquet



Co-authored-by: Jean-François Morcillo <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jun 26, 2023

Build failed:

Fix test
0d0229f 
Signed-off-by: Jean-François Morcillo <[email protected]>
@bilboquet
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jun 27, 2023
@bors
Try #261:
88dadb1
@bors
Copy link
Contributor

bors bot commented Jun 27, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bilboquet
Copy link
Contributor Author

bors merge

@bilboquet bilboquet mentioned this pull request Jun 27, 2023
Closed
@bors
Copy link
Contributor

bors bot commented Jun 27, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit afed9fa into main Jun 27, 2023
13 checks passed
@bors bors bot deleted the bilboquet/issue258 branch June 27, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damip damip damip left review comments

@AurelienFT AurelienFT AurelienFT approved these changes

@aoudiamoncef aoudiamoncef Awaiting requested review from aoudiamoncef

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bilboquet @aoudiamoncef @damip @AurelienFT