add_recursion_counter #333
Open
+44
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sydhds
approved these changes
Jul 16, 2024
damip
reviewed
Aug 5, 2024
| @@ -38,6 +38,8 @@ pub(crate) fn call_module( | |||
| ))) | |||
| })?; | |||
|
|
|||
| interface.increment_recursion_counter()?; | |||
There was a problem hiding this comment.
doesn't that double-count with the increment that happens also in init_call ?
damip
reviewed
Aug 5, 2024
| @@ -49,6 +51,8 @@ pub(crate) fn call_module( | |||
| if cfg!(not(feature = "gas_calibration")) { | |||
| set_remaining_points(&env, ctx, resp.remaining_gas)?; | |||
| } | |||
|
|
|||
| interface.decrement_recursion_counter()?; | |||
There was a problem hiding this comment.
doesn't this double-decrement with the decrement in finish_call ?
damip
reviewed
Aug 5, 2024
| @@ -152,6 +152,9 @@ fn abi_call(store_env: FunctionEnvMut<ABIEnv>, arg_offset: i32) -> Result<i32, W | |||
| let remaining_gas = handler.get_remaining_gas(); | |||
| let interface = handler.exec_env.get_interface(); | |||
| let module = helper_get_module(interface, bytecode, remaining_gas)?; | |||
| interface.increment_recursion_counter().map_err(|e| { | |||
There was a problem hiding this comment.
double-counts with the init_call_wasmv1
damip
reviewed
Aug 5, 2024
| @@ -161,6 +164,9 @@ fn abi_call(store_env: FunctionEnvMut<ABIEnv>, arg_offset: i32) -> Result<i32, W | |||
| handler.get_gas_costs().clone(), | |||
| ) | |||
| .map_err(|err| WasmV1Error::RuntimeError(format!("Could not run function: {}", err)))?; | |||
| interface.decrement_recursion_counter().map_err(|e| { | |||
There was a problem hiding this comment.
double-decrements with the finish_call below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.