Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

77 add poweredby #82

Closed
wants to merge 11 commits into from
Closed

77 add poweredby #82

wants to merge 11 commits into from

Conversation

windushka
Copy link
Contributor

aims to solve #77

@windushka windushka requested a review from Ben-Rey July 5, 2023 14:57
@Ben-Rey Ben-Rey requested a review from julienbrs July 5, 2023 18:47
Comment on lines 6 to 10
**License:** n/a - perpetual

**Used version:** n/a

**Many thanks to:** n/a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got no values for each section, can you try to fix it ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I don't really see why these values are generated empty whereas the names are not. The script seems to handle the JSON the right way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you see if there is a difference with the repo where it works?
Don't spend more than 30 minutes on it.

@Ben-Rey Ben-Rey closed this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants