Add MNS support in MW #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thykof
requested changes
May 14, 2024
pivilartisant
force-pushed
the
add-MNS-feature
branch
2 times, most recently
from
7439609
to
59e57fa
Compare
Thykof
reviewed
May 14, 2024
pivilartisant
force-pushed
the
add-MNS-feature
branch
from
59e57fa
to
178a73a
Compare
pivilartisant
force-pushed
the
add-MNS-feature
branch
from
178a73a
to
0641b4e
Compare
Thykof
reviewed
May 15, 2024
pivilartisant
force-pushed
the
add-MNS-feature
branch
from
c4b2b27
to
10ea73d
Compare
Thykof
reviewed
May 15, 2024
web-frontend/src/pages/TransferCoins/SendCoins/SendConfirmation.tsx
Outdated
Show resolved
Hide resolved
web-frontend/src/pages/TransferCoins/SendCoins/SendConfirmation.tsx
Outdated
Show resolved
Hide resolved
pivilartisant
force-pushed
the
add-MNS-feature
branch
from
75516e5
to
44cdac1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #940 +/- ##
==========================================
- Coverage 53.34% 52.52% -0.83%
==========================================
Files 43 46 +3
Lines 2433 2753 +320
==========================================
+ Hits 1298 1446 +148
- Misses 955 1118 +163
- Partials 180 189 +9 ☔ View full report in Codecov by Sentry. |
Thykof
reviewed
May 16, 2024
|
pivilartisant
commented
May 16, 2024
Thykof
approved these changes
May 17, 2024
Thykof
reviewed
May 20, 2024
Thykof
requested changes
May 20, 2024
Thykof
approved these changes
May 21, 2024
Thykof
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are adding MNS integration into Massa Wallet. This includes a display of the domain that target your massa wallet in the home page.
Additionally, we enable users to use these domain names as valid recipients attach to a wallet address in the send form.