Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uikit next #942

Merged
merged 8 commits into from
May 17, 2024
Merged

uikit next #942

merged 8 commits into from
May 17, 2024

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented May 16, 2024 •
edited
Loading

update the ui kit after this pr: massalabs/ui-kit#432

Wails:

  • move formatStandard into ui kit
  • use i18n of ui kit
  • use maskAddress of ui kit

Web:

  • use i18n of ui kit
  • use OperationToast and logSmartContractEvents, maskNickname, useLocalStorage, maskAddress of ui kit

@Thykof Thykof self-assigned this May 16, 2024
@Thykof Thykof marked this pull request as ready for review May 16, 2024 21:56
@Thykof Thykof changed the title wip uikit next uikit next May 17, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Thykof Thykof merged commit 0ea6636 into main May 17, 2024
17 checks passed
@Thykof Thykof deleted the ui-kit-next branch May 17, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-senechal thomas-senechal thomas-senechal approved these changes

@pivilartisant pivilartisant Awaiting requested review from pivilartisant

Assignees

@Thykof Thykof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thykof @thomas-senechal