Asset doc and perf #952
Merged
Asset doc and perf #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the same usd price is fetched several times (ETHUSD and USD tickers) moreover fetching USD price make no sense to me. why not just return 1$ ?? |
peterjah
approved these changes
Jun 6, 2024
thomas-senechal
approved these changes
Jun 6, 2024
pivilartisant
approved these changes
Jun 6, 2024
Thykof
force-pushed
the
add-bsc-tokens
branch
3 times, most recently
from
81c8e41
to
9a0c244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need the update of the ui kit after merge of massalabs/ui-kit#455