Rework buttons to allow bigger icons #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivilartisant
changed the title
mazmassa
approved these changes
Jul 20, 2023
pivilartisant
force-pushed
the
optimize-buttons
branch
3 times, most recently
from
ee8b8c0
to
01ec8ab
Compare
pivilartisant
force-pushed
the
optimize-buttons
branch
from
01ec8ab
to
699c515
Compare
mazmassa
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this is that the current button padding does the same thing as using a flexbox but doesn't allow us to add icon larger than 24px or else the icons are displaced.
this fixes this problem