comma separated values and documentation #818
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… getlocale, convertnumber
Mastermunj 090422
feat: Allows user to enter sting based values with comma separation feat: String based valid number can be passed to convert
|
@apoorvachikara Please, do not include package-lock.json file in your commits. That way it won't come in the PR as well. |
|
I have removed the package-lock.json. If you check the "file changed" tab - the lock file is removed from there. I removed it long back from the code. Why it is conflicting that the file is not present in the PR? |
|
Okay, so basically you do not need to delete the file. Let the file be there as it is. Make changes in the other files and commit those files in a branch and raise a PR. |
|
I made the changes can you check now? Is it fine now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.