Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected boost bind deprecation warning #104

Conversation

jeppefrandsen
Copy link

Fixes issue #98

@jeppefrandsen
Copy link
Author

@mat007 can you have a look? Thanks a lot 🍻

Copy link
Owner

@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven’t been following Boost lately (as in «in the past 5 years or so» 😁), what’s the difference between boost/bind.hpp and boost/bind/bind.hpp? Do you have a link that explains why including the latter does not issue a deprecation warning?

@mat007
Copy link
Owner

mat007 commented Oct 26, 2021

Also they are other includes to boost/bind.hpp, should they not be updated as well?
See https://github.com/mat007/turtle/search?q=bind.hpp

@jeppefrandsen
Copy link
Author

@mat007 you can read more here https://stackoverflow.com/questions/53203970/why-boostbind-insists-pulling-boostplaceholders-into-global-namespace but makes sense to update the tests as well at some point (will see if I can find a bit of time) but caused build issues as first.

@Flamefire
Copy link
Collaborator

Fixed as a side effect of #88
Thanks anyway!

@Flamefire Flamefire closed this Jan 24, 2022
@jeppefrandsen
Copy link
Author

Great @Flamefire 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants