Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #361

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

solution #361

wants to merge 5 commits into from

Conversation

Poviakalo
Copy link

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-01-10 at 14 09 16
Screenshot 2024-01-10 at 14 09 21
Please, check the layout here
Screenshot 2024-01-10 at 14 07 39
These links should open the social network in the new tab
Screenshot 2024-01-10 at 14 07 23
There is a space under the footer
Screenshot 2024-01-10 at 14 07 06
The form leads to the 404 page
Screenshot 2024-01-10 at 14 06 55
Consider fixing autocomplete styles

…shop__nav-list, added addresses to social networks
@Poviakalo
Copy link
Author

image

  • I didn't find the space under the footer.
  • I couldn't rewrite rules autocomlete, so I canceled them

Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. add hover effects for images
  2. Add paddings for main section here
    image
  3. after form submit
    image

Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. make fields in form required

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Approve.
Suggest a couple improvements which you can make during preparing project for portfolio:

Screenshot from 2024-01-16 14-35-41
Screenshot from 2024-01-16 14-31-32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants