Eco landing page #386
Eco landing page #386
Conversation
src/index.html
Outdated
| type="tel" | ||
| name="number" | ||
| placeholder="phone number" | ||
| required pattern="^\+380\d{9}$" |
There was a problem hiding this comment.
"required" should be in one line, and "pattern" in other.
Just identation fixing
src/index.html
Outdated
| type="text" | ||
| name="name" | ||
| placeholder="Your name" | ||
| required pattern="\w+" |
There was a problem hiding this comment.
Add a line break between required and pattern
src/index.html
Outdated
| type="email" | ||
| name="email" | ||
| placeholder="e-mail" | ||
| required class="form__input input" |
There was a problem hiding this comment.
Add a line break between required and class
| } | ||
| } | ||
|
|
||
| @import 'sections/header'; |
There was a problem hiding this comment.
Move all these imports to the file begining, please
There was a problem hiding this comment.
Hey, @HigorPedroso! Sorry for the delay on this review, but good job. I pointed out just a few minor improvements, and it should be good to go! 👏
src/index.html
Outdated
| </li> | ||
|
|
||
| <li class="menu__item"> | ||
| <a href="#contact" class="menu__link">Contact</a> |
There was a problem hiding this comment.
This links to #contact but your contact block has id="contacts", ending with s.
| </li> | ||
|
|
||
| <li class="nav-footer__item"> | ||
| <a href="#contact" class="nav-footer__link link-hover"> |
There was a problem hiding this comment.
This links to #contact but your contact block has id="contacts", ending with s.
src/index.html
Outdated
| LEARN MORE | ||
| </a> | ||
|
|
||
| <a href="#shop" class="section__button button"> |
There was a problem hiding this comment.
This link should probably reference #contacts and not #shop
src/index.html
Outdated
| <input | ||
| type="tel" | ||
| name="number" | ||
| placeholder="phone number" |
There was a problem hiding this comment.
Placeholder should be a sample of a valid value for this input (specially when you have custom validation patterns)
src/index.html
Outdated
| name="name" | ||
| placeholder="Your name" | ||
| required | ||
| pattern="\w+" |
There was a problem hiding this comment.
This pattern restricts the input to be a single word without spaces; it also accepts numbers and underscores. Perhaps [A-Za-z ]*[A-Za-z] would be more fitting.
DEMO LINK