Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #1141

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add task solution #1141

wants to merge 3 commits into from

Conversation

alexmotalex
Copy link

volodymyr-soltys97
volodymyr-soltys97 suggested changes Jan 22, 2025
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
To improve:
Add a favicon on the page
image

A loss message is displayed even if the game can be continued
image

vadiimvooo
vadiimvooo suggested changes Jan 22, 2025
View reviewed changes
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, but there is still loss message even in case we have possible moves. Please fix it. Don't hesitate to ask for help in fe_chat.
image

TarasHoliuk
TarasHoliuk approved these changes Jan 22, 2025
View reviewed changes
Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done ✔️ Approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarasHoliuk TarasHoliuk TarasHoliuk approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

@vadiimvooo vadiimvooo Awaiting requested review from vadiimvooo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexmotalex @volodymyr-soltys97 @TarasHoliuk @vadiimvooo