Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1514

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #1514

wants to merge 3 commits into from

Conversation

igols
Copy link

@igols igols commented Oct 7, 2024

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Make sure to deploy your page

@igols
Copy link
Author

igols commented Oct 7, 2024

_ No description provided. _
https://igols.github.io/js_get_data_DOM/

@igols igols closed this Oct 7, 2024
@igols igols reopened this Oct 7, 2024
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider fixing the solution to get calculated data

@@ -1,3 +1,22 @@
'use strict';

// write your code here
const population = [...document.querySelector(`.population`)];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const population = [...document.querySelector(`.population`)];
const population = [...document.querySelectorAll(`.population`)];

@@ -1,3 +1,22 @@
'use strict';

// write your code here
const population = [...document.querySelector(`.population`)];
const countCountries = population.length();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const countCountries = population.length();
const countCountries = population.length;

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, these part of the task are incomplete
image
image

@igols
Copy link
Author

igols commented Oct 8, 2024

_ No description provided. _

@igols igols closed this Oct 8, 2024
@igols igols reopened this Oct 8, 2024
@igols
Copy link
Author

igols commented Oct 8, 2024

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🔥

@@ -1,3 +1,24 @@
'use strict';

// write your code here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// write your code here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants