Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added initial solution #2676

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

added initial solution #2676

Changes from 16 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
efa2ecd
added initial solution
vkryvytskyy Apr 3, 2024
a946d53
solution 2
vkryvytskyy Apr 4, 2024
6831bb9
solution 3
vkryvytskyy Apr 5, 2024
0c9c947
solution 4
vkryvytskyy Apr 5, 2024
b67f7e2
solution 5
vkryvytskyy Apr 5, 2024
66f7d93
solution 6
vkryvytskyy Apr 8, 2024
412eb24
solution 7
vkryvytskyy Apr 8, 2024
2c949bd
solution 8
vkryvytskyy Apr 8, 2024
07d32d3
solution 9
vkryvytskyy Apr 8, 2024
727503c
solution 10
vkryvytskyy Apr 8, 2024
a44140d
solution 9.2
vkryvytskyy Apr 9, 2024
6320c61
solution 8.2
vkryvytskyy Apr 9, 2024
b589d37
top solution
vkryvytskyy Apr 15, 2024
408ab78
top solution fixed
vkryvytskyy Apr 15, 2024
fc864ed
top solution fixed 2
vkryvytskyy Apr 15, 2024
297f3ed
top solution fixed 3
vkryvytskyy Apr 15, 2024
c1b5609
top solution fixed 4
vkryvytskyy Apr 15, 2024
0d59f06
new solution
vkryvytskyy Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/inverseRobot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,17 @@
*/

function inverseRobot(robot) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to add a function description using JSDoc comments. This helps other developers understand what the function does, its parameters, and its return value.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to add a brief comment describing what your function does. This will help other developers understand your code more easily.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a check to ensure that the 'robot' parameter is indeed an object and not null or undefined. This can prevent potential runtime errors if the function is called with invalid arguments.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function 'inverseRobot' is correctly named and describes its purpose well.

// write code here
const invertedRobot = {};

for (const key in robot) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended to use Object.keys() or Object.entries() to iterate over an object. This way, you don't have to worry about properties that come from the object's prototype.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using Object.keys(robot) or Object.entries(robot) to iterate over the properties of the robot object. This approach avoids iterating over properties in the prototype chain and is generally considered a best practice when you only want to deal with the object's own properties.

if (Object.prototype.hasOwnProperty.call(invertedRobot, robot[key])) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check for property presence is correct, but it's not necessary to use Object.prototype.hasOwnProperty.call here. Instead, you can directly check if the value exists in the invertedRobot object using invertedRobot.hasOwnProperty(robot[key]) or robot[key] in invertedRobot which is more concise and easier to read.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Object.prototype.hasOwnProperty.call is a safe way to check for property existence. However, since you are creating a new object invertedRobot which does not inherit from anything, you can use the simpler invertedRobot.hasOwnProperty(robot[key]) or even robot[key] in invertedRobot for readability.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check for property presence is correct, but the object you should be checking is the 'robot' object, not the 'invertedRobot'. You want to ensure that each value in the 'robot' object is unique before assigning it as a key in 'invertedRobot'.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check for property presence using 'Object.prototype.hasOwnProperty.call' is correct and ensures that the property comes directly from the object rather than its prototype chain.

return null;
}

invertedRobot[String(robot[key])] = key;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explicit conversion to 'String' is not necessary because object keys are always strings in JavaScript. If the value is not a string, it will be coerced to a string automatically.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explicit conversion to String is not necessary when setting the property on 'invertedRobot'. Object keys are automatically converted to strings in JavaScript, so you can directly use 'invertedRobot[robot[key]] = key;'.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of String(robot[key]) is redundant since the object values are already strings or can be implicitly converted to strings when used as property keys.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good practice to check if robot[key] is not undefined or null before adding it to invertedRobot to ensure that all keys in the inverted object are valid.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of String(robot[key]) is redundant here since object keys are automatically converted to strings. You can directly assign invertedRobot[robot[key]] = key;.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using String(robot[key]) is unnecessary since object keys are always strings. If the value is not a string, it will be coerced to a string automatically when used as a property key.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 'String(robot[key])' is redundant since object keys are always strings. You can directly use 'robot[key]' as the key for 'invertedRobot'.

}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InversedRobot, use inversedRobot instead of robot.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to avoid using nested for loops


return invertedRobot;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function correctly returns the 'invertedRobot' object if no duplicate values are found in the input 'robot' object.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning the invertedRobot object is correct. The function will return either null if a duplicate value is found or the inverted object otherwise, adhering to the task requirements.

}

module.exports = inverseRobot;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good practice to include a newline at the end of the file. Some tools and systems expect or require it for proper processing.

Loading