-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #2561
base: master
Are you sure you want to change the base?
Solution #2561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
But let's make your code perfect
src/transformState.js
Outdated
} | ||
break; | ||
default: | ||
return Error('Bad action type'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returning an Error object won't actually throw an error. Consider throwing the error instead, like 'throw new Error('Bad action type')'.
src/transformState.js
Outdated
for (const action of actions) { | ||
switch (action.type) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use destructurization here for action
for (const action of actions) { | |
switch (action.type) { | |
for (const action of actions) { | |
const {} = action; | |
switch (action.type) { |
No description provided.