Solution #2572
Open
Solution #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Jul 18, 2023
src/transformState.js
Outdated
| @@ -5,7 +5,31 @@ | |||
| * @param {Object[]} actions | |||
| */ | |||
| function transformState(state, actions) { | |||
| // write code here | |||
| for (const action of actions) { | |||
| const valueOfType = action['type']; | |||
There was a problem hiding this comment.
The name 'valueOfType' could be more descriptive. Consider renaming it to 'actionType' to better represent its content.
src/transformState.js
Outdated
Comment on lines
8
to
9
| for (const action of actions) { | ||
| const valueOfType = action['type']; |
There was a problem hiding this comment.
You can use a desctructurization here for action
Suggested change
| for (const action of actions) { | |
| const valueOfType = action['type']; | |
| for (const action of actions) { | |
| const {} = action; |
anastasiiavorobiova
suggested changes
Jul 18, 2023
src/transformState.js
Outdated
|
|
||
| switch (type) { | ||
| case 'addProperties': | ||
| (Object.assign(state, action['extraData'])); |
There was a problem hiding this comment.
Suggested change
| (Object.assign(state, action['extraData'])); | |
| (Object.assign(state, action.extraData)); |
There is no need to use dynamic keys. Consider using static keys or using destructuring
src/transformState.js
Outdated
| break; | ||
|
|
||
| case 'removeProperties': | ||
| for (const keyToDelete of action['keysToRemove']) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.