-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added transformState #2575
base: master
Are you sure you want to change the base?
Added transformState #2575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost perfect) Let's improve
src/transformState.js
Outdated
@@ -5,7 +5,29 @@ | |||
* @param {Object[]} actions | |||
*/ | |||
function transformState(state, actions) { | |||
// write code here | |||
for (const action of actions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Destructure action
src/transformState.js
Outdated
break; | ||
case 'removeProperties': | ||
for (const key of action.keysToRemove) { | ||
if (state.hasOwnProperty(key)) { | ||
delete state[key]; | ||
} | ||
} | ||
break; | ||
case 'clear': | ||
for (const key in state) { | ||
if (state.hasOwnProperty(key)) { | ||
delete state[key]; | ||
} | ||
} | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add empty line between cases
break; | |
case 'removeProperties': | |
for (const key of action.keysToRemove) { | |
if (state.hasOwnProperty(key)) { | |
delete state[key]; | |
} | |
} | |
break; | |
case 'clear': | |
for (const key in state) { | |
if (state.hasOwnProperty(key)) { | |
delete state[key]; | |
} | |
} | |
break; | |
break; | |
case 'removeProperties': | |
for (const key of action.keysToRemove) { | |
if (state.hasOwnProperty(key)) { | |
delete state[key]; | |
} | |
} | |
break; | |
case 'clear': | |
for (const key in state) { | |
if (state.hasOwnProperty(key)) { | |
delete state[key]; | |
} | |
} | |
break; | |
src/transformState.js
Outdated
for (const key in state) { | ||
if (state.hasOwnProperty(key)) { | ||
delete state[key]; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check redundant this key will be because you loop through it from this object
for (const key in state) { | |
if (state.hasOwnProperty(key)) { | |
delete state[key]; | |
} | |
} | |
for (const key in state) { | |
delete state[key]; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ 🚀
No description provided.