Solution #2602
Open
Solution #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choeqq
suggested changes
Jul 26, 2023
src/transformState.js
Outdated
Comment on lines
13
to
15
| for (const key in extraData) { | ||
| state[key] = extraData[key]; | ||
| } |
There was a problem hiding this comment.
there are special method for that: Object.assign()
src/transformState.js
Outdated
Comment on lines
34
to
35
| default: | ||
| break; |
There was a problem hiding this comment.
break provide some kind of Error message
| break; | ||
|
|
||
| case 'removeProperties': | ||
| const keysToRemove = currentAction.keysToRemove; |
| for (const currentAction of actions) { | ||
| switch (currentAction.type) { | ||
| case 'addProperties': | ||
| const extraData = currentAction.extraData; |
choeqq
suggested changes
Jul 27, 2023
JoyCoffeeAddict
suggested changes
Jul 27, 2023
choeqq
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
That looks alright, but please remember about object destructuring ✅
choeqq
approved these changes
Aug 8, 2023
ihor-jpeg
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.