solution #2682
Open
solution #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loralevitska
suggested changes
Aug 3, 2023
src/transformState.js
Outdated
| break; | ||
|
|
||
| case 'removeProperties': | ||
| if (actions[i].keysToRemove !== undefined) { |
There was a problem hiding this comment.
There's no need for checking if 'keysToRemove' is undefined. If it's undefined, the later for loop just won't execute.
src/transformState.js
Outdated
| @@ -5,7 +5,34 @@ | |||
| * @param {Object[]} actions | |||
| */ | |||
| function transformState(state, actions) { | |||
| // write code here | |||
| for (let i = 0; i < actions.length; i++) { | |||
| const mainAction = actions[i].type; | |||
There was a problem hiding this comment.
Instead of traditional for loop, use of 'for...of' loop is recommended for better readability when iterating over an array.
src/transformState.js
Outdated
| @@ -5,7 +5,34 @@ | |||
| * @param {Object[]} actions | |||
| */ | |||
| function transformState(state, actions) { | |||
| // write code here | |||
| for (let i = 0; i < actions.length; i++) { | |||
| const mainAction = actions[i].type; | |||
There was a problem hiding this comment.
Destructure action
const { type, extraData, keysToRemove } = actions[i]
VitaliyBodnar
suggested changes
Aug 3, 2023
src/transformState.js
Outdated
| break; | ||
|
|
||
| case 'removeProperties': | ||
| const toRemove = keysToRemove; |
src/transformState.js
Outdated
Comment on lines
27
to
29
| for (let j = 0; j < toRemove.length; j++) { | ||
| delete state[toRemove[j]]; | ||
| } |
There was a problem hiding this comment.
don't see any sense in using for loop, better to use for of or forEach here
polosanya
suggested changes
Aug 4, 2023
OleziO
suggested changes
Aug 4, 2023
src/transformState.js
Outdated
| const { type, extraData, keysToRemove } = action; | ||
|
|
||
| switch (type) { | ||
| case 'clear': |
There was a problem hiding this comment.
Move all cases to the object.
Example of usage:
case ActionType.Clear:
VitaliyBodnar
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.