Develop #2687
Open
Develop #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanFesenko
suggested changes
Aug 4, 2023
src/transformState.js
Outdated
Comment on lines
20
to
23
| default: | ||
| for (const key in state) { | ||
| delete state[key]; | ||
| } |
There was a problem hiding this comment.
Add separete case for delete. By default should be an error in case wrong action
IvanFesenko
suggested changes
Aug 4, 2023
src/transformState.js
Outdated
Comment on lines
20
to
25
| case 'clear': | ||
| for (const key in state) { | ||
| delete state[key]; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Where is default case?
Please check checklist
mykhalenych
approved these changes
Aug 4, 2023
| @@ -5,7 +5,28 @@ | |||
| * @param {Object[]} actions | |||
| */ | |||
| function transformState(state, actions) { | |||
| // write code here | |||
| for (const action of actions) { | |||
| switch (action.type) { | |||
There was a problem hiding this comment.
you can destruct action
const {type, extraData, keysToRemove) = action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.