-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
finish solution #2696
base: master
Are you sure you want to change the base?
finish solution #2696
Conversation
src/transformState.js
Outdated
Object.assign(state, action.extraData); | ||
|
||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these gaps are redundant here
src/transformState.js
Outdated
for (const key of action.keysToRemove) { | ||
delete state[key]; | ||
} | ||
|
||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same with gaps here + if you have few lines inside of case block - better to add curly braces + let's use array methods here and everywhere else ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job👍
No description provided.