Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #2700

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions src/transformState.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,38 @@
*/
function transformState(state, actions) {
// write code here
for (const action of actions) {
const { type } = action;

switch (type) {
case 'addProperties':
const { extraData } = action;

for (const key in extraData) {
state[key] = extraData[key];
}
break;

case 'removeProperties':
const { keysToRemove } = action;

if (keysToRemove) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary condition. If 'keysToRemove' is not provided, the for...of loop will simply not run. Therefore, the if (keysToRemove) condition is redundant and can be removed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fixed

for (const key of keysToRemove) {
delete state[key];
}
}
break;

case 'clear':
for (const key in state) {
delete state[key];
}
break;

default:
throw new Error(`Unknown action type: ${type}`);
}
}
}

module.exports = transformState;
Loading