add my ugly solution. i think so, maybe not)) #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasiiavorobiova
suggested changes
Aug 8, 2023
src/transformState.js
Outdated
| // write code here | ||
| function transformState(state, action) { | ||
| for (const obj of action) { | ||
| // to iterate all objects in array. |
There was a problem hiding this comment.
Consider removing redundant comments
src/transformState.js
Outdated
| for (const [key, value] of Object.entries(obj)) { | ||
| // to iterate every object and split on keys and values. | ||
| // | ||
| // conditions check |
There was a problem hiding this comment.
Consider removing redundant comments
src/transformState.js
Outdated
| } | ||
|
|
||
| if (obj[key] === obj.extraData) { | ||
| // add key and value to the object |
There was a problem hiding this comment.
Consider removing redundant comments
src/transformState.js
Outdated
| } | ||
|
|
||
| if (obj[key] === obj.keysToRemove) { | ||
| // delete properies |
There was a problem hiding this comment.
Consider removing redundant comments
| @@ -4,8 +4,36 @@ | |||
| * @param {Object} state | |||
| * @param {Object[]} actions | |||
| */ | |||
| function transformState(state, actions) { | |||
There was a problem hiding this comment.
You can place here a bunch of helper constants, for example:
const CLEAR = 'clear';
And use it instead of magic strings (a considered programming antipattern) in your code
src/transformState.js
Outdated
|
|
||
| if (obj[key] === obj.extraData) { | ||
| // add key and value to the object | ||
| for (const [k, v] of Object.entries(obj[key])) { |
There was a problem hiding this comment.
Consider using Object.assign instead of looping through every key
loralevitska
approved these changes
Aug 8, 2023
| function transformState(state, action) { | ||
| const CLEAR = 'clear'; | ||
|
|
||
| for (const obj of action) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like it works