Add Injector with Component #1021
Conversation
There was a problem hiding this comment.
Great job on implementing the dependency injection pattern and ensuring all components work seamlessly together! 🎉 While there are minor suggestions like checking the instances map before creating new instances and adding the @Target annotation to custom annotations, these do not impact the core functionality. Keep up the good work and consider these improvements for future projects! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| @Retention(RetentionPolicy.RUNTIME) | ||
| public @interface Inject { |
There was a problem hiding this comment.
Consider adding the @Target annotation to specify where this annotation can be applied. According to the checklist, you should not forget to add @Target to custom annotations .
|
|
||
| public static Injector getInjector() { | ||
| return injector; | ||
| } | ||
|
|
||
| public Object getInstance(Class<?> interfaceClazz) { | ||
| return null; | ||
| if (instances.containsKey(interfaceClazz)) { |
There was a problem hiding this comment.
According to the checklist, you should check the instances map before creating a new instance. This ensures that you are not unnecessarily creating new instances when an instance already exists.
No description provided.